Pascal Hambourg
2025-01-04 23:30:01 UTC
Reply
PermalinkVersion: 91
Tags: patch
The call to clean_method() was lost with commit cfc6797f (Factor out the
creation of Physical Volume partitions).
Without this call, partitions on other disks may be used in addition to
the partitions created by the recipe. As a result,
- such filesystem partitions will keep their mount points and may
conflict with the mount points created by the recipe;
- such swap partitions will be used;
- any such EFI partition may be used instead of the EFI partition
created by the recipe.
(Note: Undesired use of other EFI partitions may also be caused by
another bug in partman-efi, see #1034208 #1034812 #1041168 for details)
Steps to reproduce:
(This is an unrealistic use case for easy demonstration)
- Boot the installer with two blank disks, preferably in EFI mode.
- Use guided partitioning (no LVM) on disk 1.
- Enter and exit LVM or RAID configuration (to commit changes).
- Use guided partitioning with LVM (no encryption) on disk 2.
Outcome: see attached screenshot.
The partitions on disk 1 are still set up for use. "Write changes to
disk" will fail because of the conflicting mount points and the EFI
partition on disk 1 will be used instead of the one on disk 2.
The obvious fix is to restore the call to clean_method() to prevent
this, like in partman-auto and partman-auto-crypto. Patch submitted:
<https://salsa.debian.org/installer-team/partman-auto-lvm/-/merge_requests/6>