Bug#1034208: Partman may reset user's choice for ESP partitions use

[Pascal Hambourg]

Package: partman-efi
Severity: minor

Boot method: USB stick
Image version: debian-bookworm-DI-rc1-amd64-netinst.iso

Dear maintainer,

as discussed in #debian-boot (you asked for it), I observed that partman
resets the method set by the user on ESP partitions after setting LVM or
RAID (and possibly encryption, I forgot to test).

Prerequisite: existing ESP partition(s).

Steps to reproduce:
- Select manual partitioning. All ESP partitions are set "use as: ESP"
by default.
- Select an existing ESP partition and set it "do not use".
- Enter LVM or RAID setup.
- Leave LVM or RAID setup (no need to make any change).

Outcome: the EFI partition is set to "use as: ESP" again.

This is caused by /lib/partman/init.d/50efi rewriting "efi" to $id/
method when being re-run after leaving LVM/RAID setup.

Suggested fix: do not rewrite $id/method if
/var/lib/partman/uefi_check_done exists, either by moving the check
before the device loop (my preferred) or by adding a check before
writing the method.

Use case: on multiboot systems I have multiple ESP partitions (possibly
on multiple disks) and wish to force which one will be used for
installation, so I need to disable the others.

[Debian Bug Tracking System]

tags -1 patch

Bug #1034208 [partman-efi] Partman may reset user's choice for ESP partitions use
Added tag(s) patch.

[Pascal Hambourg]

Control: retitle -1 Partman may use the wrong ESP partition

Here are patches implementing the two versions of the above fix.

It seems that this patch is also needed to fix #1034812 (guided
partitioning with LVM uses the wrong ESP), in combination with another
(trivial) patch for partman-auto-lvm.

Updating the title accordingly.

[Debian Bug Tracking System]

Post by Pascal Hambourg
retitle -1 Partman may use the wrong ESP partition

Bug #1034208 [partman-efi] Partman may reset user's choice for ESP partitions use
Changed Bug title to 'Partman may use the wrong ESP partition' from 'Partman may reset user's choice for ESP partitions use'.

[Debian Bug Tracking System]

Your message dated Fri, 17 Jan 2025 22:37:06 +0000
with message-id <E1tYuxe-002hgc-***@fasolo.debian.org>
and subject line Bug#1034208: fixed in partman-efi 108
has caused the Debian Bug report #1034208,
regarding Partman may use the wrong ESP partition
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ***@bugs.debian.org
immediately.)