Bug#1086476: kbd-chooser: Please add build support for loong64

[zhangdandan]

Source: kbd-chooser
Version: 1.71
Severity: normal
Tags: ftbfs patch
User: debian-***@lists.debian.org
Usertags: loong64

Hi maintainers,

The status of kbd-chooser for loong64 is Auto-Not-For-Us.
We need to add build support for loong64 in d/control.
Please consider the patch I attached.
Based on the attached patch, I have built kbd-chooser successfully on my
local ENV.
```
  dh_builddeb
dpkg-deb: building package 'kbd-chooser' in
'debian/.debhelper/scratch-space/build-kbd-chooser/kbd-chooser_1.71+loong64_loong64.deb'.
    Renaming kbd-chooser_1.71+loong64_loong64.deb to
kbd-chooser_1.71+loong64_loong64.udeb
 dpkg-genbuildinfo -O../kbd-chooser_1.71+loong64_loong64.buildinfo
 dpkg-genchanges -O../kbd-chooser_1.71+loong64_loong64.changes
```

I checked that kbd-chooser is a key package for Debian release.
Could you add the loong64 support in the next upload?
Or, maybe please consider to use "linux-any" in d/control.

Best regards,
Dandan Zhang

[Debian Bug Tracking System]

tags 1086476 + patch

Bug #1086476 [src:kbd-chooser] kbd-chooser: Please add build support for loong64
Ignoring request to alter tags of bug #1086476 to the same tags previously set

tags 1086476 + pending

Bug #1086476 [src:kbd-chooser] kbd-chooser: Please add build support for loong64
Added tag(s) pending.

[Chris Hofstaedtler]

-Architecture: i386 ia64 hppa alpha sparc mips mipsel mips64el arm armel armeb armhf m68k powerpc amd64 sh4 sparc64 arm64 ppc64el
+Architecture: i386 ia64 hppa alpha sparc mips mipsel mips64el arm armel armeb armhf m68k powerpc amd64 sh4 sparc64 arm64 ppc64el loong64

Is there a reason this is not "linux-any"?

Chris

[John Paul Adrian Glaubitz]

Hi Gianfranco,

I've prepared an NMU for kbd-chooser (versioned as 1.71+nmu1) and
uploaded it to DELAYED/10. Please feel free to tell me if I
should delay it longer.

Why the NMU? I would rather have Holger Wansing take care of such changes
in the d-i code. He's got a better overview of all the bits and pieces
and their current state and I think he can take care of this particular
change as well.

I also agree to what Chris said, we should just use "linux-any".

Holger, could you take care of this and change the architecture list for
kbd-chooser to "linux-any" unless there is a particular reason not to?

Adrian

[Holger Wansing]

Hi,

Post by John Paul Adrian Glaubitz
Hi Gianfranco,

I've prepared an NMU for kbd-chooser (versioned as 1.71+nmu1) and
uploaded it to DELAYED/10. Please feel free to tell me if I
should delay it longer.

Why the NMU? I would rather have Holger Wansing take care of such changes
in the d-i code. He's got a better overview of all the bits and pieces
and their current state and I think he can take care of this particular
change as well.
I also agree to what Chris said, we should just use "linux-any".
Holger, could you take care of this and change the architecture list for
kbd-chooser to "linux-any" unless there is a particular reason not to?

I was under the impression, that kbd-chooser is no longer in use...
Many years ago d-i switched away from kbd-chooser to console-setup
AFAIK.

There is no occurrence of "kbd-chooser" in
<https://salsa.debian.org/installer-team/debian-installer/-/tree/master/build/config?ref_type=heads>

And kbd-chooser is an udeb-only package.

So, is kbd-chooser still in use somehow???
Am I missing something?



Holger

[Cyril Brulebois]

Post by Holger Wansing
I was under the impression, that kbd-chooser is no longer in use...
Many years ago d-i switched away from kbd-chooser to console-setup
AFAIK.
There is no occurrence of "kbd-chooser" in
<https://salsa.debian.org/installer-team/debian-installer/-/tree/master/build/config?ref_type=heads>
And kbd-chooser is an udeb-only package.
So, is kbd-chooser still in use somehow???
Am I missing something?

It looks like we're running in circles (not your fault), another
occurrence earlier this year:
https://lists.debian.org/debian-boot/2024/05/msg00026.html

I concur with your analysis, only seeing kbd-choose referenced mostly
through comments or changelog entries in other packages (e.g.
live-installer, kickseed, localechooser, preseed), so it seems to me
it's no used anymore.


Cheers,

[Holger Wansing]

Hi,

Post by Cyril Brulebois

Post by Holger Wansing
I was under the impression, that kbd-chooser is no longer in use...
Many years ago d-i switched away from kbd-chooser to console-setup
AFAIK.
There is no occurrence of "kbd-chooser" in
<https://salsa.debian.org/installer-team/debian-installer/-/tree/master/build/config?ref_type=heads>
And kbd-chooser is an udeb-only package.
So, is kbd-chooser still in use somehow???
Am I missing something?

It looks like we're running in circles (not your fault), another
https://lists.debian.org/debian-boot/2024/05/msg00026.html

That seems to ring a bell here:
some weeks ago I had some writing with Phil Hands, and
that lead to me noticing, that kbd-chooser is included in our
netboot images and as well in mini.iso images built by Phil's
branch2repo CI on Salsa.

I wonder how or why kbd-chooser is included in that images?
There seems to be another mechanism for building d-i images,
besides the above mentioned
<https://salsa.debian.org/installer-team/debian-installer/-/tree/master/build/config?ref_type=heads>

That will be debian-cd I guess, but I couldn't find any mention
of kbd-chooser in debian-cd...

At that point I stumbled and later forgot about this.

Will debian-cd builds break, when kbd-chooser is removed from
the archive?

Post by Cyril Brulebois
I concur with your analysis, only seeing kbd-choose referenced mostly
through comments or changelog entries in other packages (e.g.
live-installer, kickseed, localechooser, preseed), so it seems to me
it's no used anymore.

Holger

[Cyril Brulebois]

Adding debian-cd@ to the loop to be extra sure we're not missing anything
obvious


Post by Holger Wansing
some weeks ago I had some writing with Phil Hands, and
that lead to me noticing, that kbd-chooser is included in our
netboot images

I don't think so? It doesn't show up anywhere in debian-installer build logs
(as in https://buildd.debian.org/status/package.php?p=debian-installer), it
doesn't show up anywhere in debian-installer daily build logs (as in
dillon:/srv/d-i.debian.org/www/daily-images).

Post by Holger Wansing
and as well in mini.iso images built by Phil's branch2repo CI on Salsa.

I can imagine why that would be the case but I'm not going to look into that
given past events.

Post by Holger Wansing
That will be debian-cd I guess, but I couldn't find any mention of
kbd-chooser in debian-cd...

I don't see why debian-cd would have to care about kbd-chooser specifically,
no.

Post by Holger Wansing
Will debian-cd builds break, when kbd-chooser is removed from the archive?

I don't think it will, and if it does, we can investigate at that point.

You can check the contents of the amd64 netinst image here:
https://cdimage.debian.org/cdimage/release/current/amd64/list-cd/debian-12.8.0-amd64-netinst.list.gz
https://cdimage.debian.org/cdimage/daily-builds/daily/current/amd64/list-cd/debian-testing-amd64-netinst.list.gz

No kbd-chooser there



Cheers,

[Holger Wansing]

Hi,

obvious…

Post by Holger Wansing
some weeks ago I had some writing with Phil Hands, and
that lead to me noticing, that kbd-chooser is included in our
netboot images

Please note, that I mention netboot images here, not netinst!

I don't think so? It doesn't show up anywhere in debian-installer build logs
(as in https://buildd.debian.org/status/package.php?p=debian-installer), it
doesn't show up anywhere in debian-installer daily build logs (as in
dillon:/srv/d-i.debian.org/www/daily-images).

Post by Holger Wansing
and as well in mini.iso images built by Phil's branch2repo CI on Salsa.

I can imagine why that would be the case but I'm not going to look into that
given past events.

Post by Holger Wansing
That will be debian-cd I guess, but I couldn't find any mention of
kbd-chooser in debian-cd...

I don't see why debian-cd would have to care about kbd-chooser specifically,
no.

Post by Holger Wansing
Will debian-cd builds break, when kbd-chooser is removed from the archive?

I don't think it will, and if it does, we can investigate at that point.
https://cdimage.debian.org/cdimage/release/current/amd64/list-cd/debian-12.8.0-amd64-netinst.list.gz
https://cdimage.debian.org/cdimage/daily-builds/daily/current/amd64/list-cd/debian-testing-amd64-netinst.list.gz
No kbd-chooser there…

Not in netinst, that's correct, but in netboot (aka mini.iso).
There I can choose kbd-chooser in expert mode via "load installer
components".



Holger

[Cyril Brulebois]

Post by Holger Wansing
Please note, that I mention netboot images here, not netinst!

Post by Cyril Brulebois
I don't think so? It doesn't show up anywhere in debian-installer build logs
(as in https://buildd.debian.org/status/package.php?p=debian-installer), it
doesn't show up anywhere in debian-installer daily build logs (as in
dillon:/srv/d-i.debian.org/www/daily-images).

↑

Post by Holger Wansing
Not in netinst, that's correct, but in netboot (aka mini.iso).
There I can choose kbd-chooser in expert mode via "load installer
components".

It's listed because it's available on the network mirror. That doesn't
mean it's included in any way in there.


Cheers,

[Holger Wansing]

Hi,

Post by Cyril Brulebois

Post by Holger Wansing
Not in netinst, that's correct, but in netboot (aka mini.iso).
There I can choose kbd-chooser in expert mode via "load installer
components".

It's listed because it's available on the network mirror. That doesn't
mean it's included in any way in there.

If I choose it, it gets loaded and a menu entry appears in the d-i main
menu.
But the step fails, when I choose the menu entry.


So, I will request its removal from unstable (if we don't get other info
from debian-cd).


Holger

[John Paul Adrian Glaubitz]

Hi Gianfranco,

Post by Holger Wansing
If I choose it, it gets loaded and a menu entry appears in the d-i main
menu.
But the step fails, when I choose the menu entry.
So, I will request its removal from unstable (if we don't get other info
from debian-cd).

Given that information, could you drop your NMU from the DELAYED queue?

Thanks,
Adrian